dylan/vod-system
1
1
Fork 0
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(maintainability): clean up reliability issues

Browse Source
This commit is contained in:
Dylan De Faoite
2026-06-25 20:36:39 +01:00
parent 5e00965baa
commit 3d57007074
6 changed files with 27 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/com/ddf/vodsystem/services/media/MetadataService.java
View File

@@ -20,6 +20,8 @@ import java.util.concurrent.Future;
public class MetadataService {
private static final Logger logger = LoggerFactory.getLogger(MetadataService.class);
private static final String DURATION = "duration";
@Async("ffmpegTaskExecutor")
public Future<ClipOptions> getVideoMetadata(Path file) {
logger.info("Getting metadata for file {}", file);
@@ -78,8 +80,8 @@ public class MetadataService {
}
private Float extractDuration(JsonNode streamNode) {
if (streamNode.has("duration")) {
return Float.valueOf(streamNode.get("duration").asText());
if (streamNode.has(DURATION)) {
return Float.valueOf(streamNode.get(DURATION).asText());
}
throw new FFMPEGException("ffprobe duration missing");
@@ -115,8 +117,8 @@ public class MetadataService {
}
private void extractEndPointFromFormat(ClipOptions metadata, JsonNode formatNode) {
if (formatNode != null && formatNode.has("duration") && metadata.getDuration() == null) {
metadata.setDuration(Float.parseFloat(formatNode.get("duration").asText()));
if (formatNode != null && formatNode.has(DURATION) && metadata.getDuration() == null) {
metadata.setDuration(Float.parseFloat(formatNode.get(DURATION).asText()));
}
}

7
src/main/java/com/ddf/vodsystem/services/media/StreamActionsService.java
View File

@@ -6,6 +6,7 @@ import org.slf4j.LoggerFactory;
import org.springframework.scheduling.annotation.Async;
import org.springframework.stereotype.Service;
import java.io.IOException;
import java.nio.file.Path;
import java.util.List;
import java.util.concurrent.CompletableFuture;
@@ -75,9 +76,13 @@ public class StreamActionsService {
progressTracker.markComplete();
return CompletableFuture.completedFuture(outputFile);
} catch (Exception e) {
} catch (IOException e) {
logger.error("Failed to save section to '{}'", outputFile, e);
return CompletableFuture.failedFuture(e);
} catch (InterruptedException e) {
logger.error("Failed to save section");
Thread.currentThread().interrupt();
return CompletableFuture.failedFuture(e);
}
}
}