From b05ae62230968ab8a507678029dd3929bb5d3ecc Mon Sep 17 00:00:00 2001 From: Dylan De Faoite Date: Sat, 20 Jun 2026 19:01:59 +0100 Subject: [PATCH] refactor(dto): use record for Token DTO --- .../ddf/vodsystem/controllers/MetadataController.java | 1 - .../com/ddf/vodsystem/controllers/UserController.java | 10 +++++----- .../java/com/ddf/vodsystem/controllers/dto/Token.java | 5 +++++ src/main/java/com/ddf/vodsystem/dto/TokenDTO.java | 10 ---------- 4 files changed, 10 insertions(+), 16 deletions(-) create mode 100644 src/main/java/com/ddf/vodsystem/controllers/dto/Token.java delete mode 100644 src/main/java/com/ddf/vodsystem/dto/TokenDTO.java diff --git a/src/main/java/com/ddf/vodsystem/controllers/MetadataController.java b/src/main/java/com/ddf/vodsystem/controllers/MetadataController.java index 0eb58e8..45f99e8 100644 --- a/src/main/java/com/ddf/vodsystem/controllers/MetadataController.java +++ b/src/main/java/com/ddf/vodsystem/controllers/MetadataController.java @@ -2,7 +2,6 @@ package com.ddf.vodsystem.controllers; import com.ddf.vodsystem.dto.ClipOptions; import com.ddf.vodsystem.dto.APIResponse; -import com.ddf.vodsystem.services.JobOrchestrationService; import com.ddf.vodsystem.services.JobRegistryService; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; diff --git a/src/main/java/com/ddf/vodsystem/controllers/UserController.java b/src/main/java/com/ddf/vodsystem/controllers/UserController.java index 401ca21..940c31d 100644 --- a/src/main/java/com/ddf/vodsystem/controllers/UserController.java +++ b/src/main/java/com/ddf/vodsystem/controllers/UserController.java @@ -1,7 +1,7 @@ package com.ddf.vodsystem.controllers; import com.ddf.vodsystem.dto.APIResponse; -import com.ddf.vodsystem.dto.TokenDTO; +import com.ddf.vodsystem.controllers.dto.Token; import com.ddf.vodsystem.entities.User; import com.ddf.vodsystem.exceptions.NotAuthenticated; import com.ddf.vodsystem.services.UserService; @@ -39,9 +39,9 @@ public class UserController { } @PostMapping("/login") - public ResponseEntity> login(@RequestBody TokenDTO tokenDTO, - HttpServletResponse response) { - String jwt = userService.login(tokenDTO.getToken()); + public ResponseEntity> login(@RequestBody Token token, + HttpServletResponse response) { + String jwt = userService.login(token.token()); ResponseCookie cookie = ResponseCookie.from("token", jwt) .httpOnly(true) @@ -54,7 +54,7 @@ public class UserController { response.addHeader("Set-Cookie", cookie.toString()); return ResponseEntity.ok( - new APIResponse<>("success", "Logged in successfully", new TokenDTO(jwt)) + new APIResponse<>("success", "Logged in successfully", new Token(jwt)) ); } diff --git a/src/main/java/com/ddf/vodsystem/controllers/dto/Token.java b/src/main/java/com/ddf/vodsystem/controllers/dto/Token.java new file mode 100644 index 0000000..e9ea3bd --- /dev/null +++ b/src/main/java/com/ddf/vodsystem/controllers/dto/Token.java @@ -0,0 +1,5 @@ +package com.ddf.vodsystem.controllers.dto; + +public record Token( + String token +) {} diff --git a/src/main/java/com/ddf/vodsystem/dto/TokenDTO.java b/src/main/java/com/ddf/vodsystem/dto/TokenDTO.java deleted file mode 100644 index 41a3f07..0000000 --- a/src/main/java/com/ddf/vodsystem/dto/TokenDTO.java +++ /dev/null @@ -1,10 +0,0 @@ -package com.ddf.vodsystem.dto; - -import lombok.AllArgsConstructor; -import lombok.Data; - -@Data -@AllArgsConstructor -public class TokenDTO { - private String token; -}